Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the hardcoded keyboard wait delay from handleKeys #784

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mykola-mokhnach
Copy link

Related to appium/appium#19245

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me. I guess this was historical something for older OS versions, which may not be necessary in recent years' ones

@Dan-Maor
Copy link
Collaborator

Dan-Maor commented Oct 3, 2023

I'm not sure about this change, waiting might still be relevant for older models. Going to run a verification on an older supported device once I get to the office tomorrow.

Copy link

@DanMPerfecto DanMPerfecto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran some tests on an iPhone 8 running iOS 15.7, looks good to me.

@mykola-mokhnach mykola-mokhnach merged commit f043d67 into master Oct 5, 2023
42 of 45 checks passed
@mykola-mokhnach mykola-mokhnach deleted the keys_tune branch October 5, 2023 08:36
github-actions bot pushed a commit that referenced this pull request Oct 5, 2023
## [5.10.1](v5.10.0...v5.10.1) (2023-10-05)

### Miscellaneous Chores

* Remove the hardcoded keyboard wait delay from handleKeys ([#784](#784)) ([f043d67](f043d67))
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

🎉 This PR is included in version 5.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants